Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving release process #65

Closed
jbruchanov opened this issue Jun 16, 2024 · 3 comments
Closed

Improving release process #65

jbruchanov opened this issue Jun 16, 2024 · 3 comments

Comments

@jbruchanov
Copy link

jbruchanov commented Jun 16, 2024

Hi thanks a lot for your work.

I'd have though few ideas for your release process...

  • Use please github release tagging, so it's easier to see what changes you are doing in newer releases if you don't have proper release notes
  • add explicit as low as possible jvmTarget, you've probably on your machine/CI updated JVM and now newer version (1.3.40+) is failing on my side with
com/ditchoom/buffer/Charset has been compiled by a more recent version of the Java Runtime (class file version 63.0), this version of the Java Runtime only recognizes class file versions up to 61.0
  • having versioning like 1.4.0 is not only for me sort sign of semver, so I'd strongly suggest to strictly follow it, so 1.3.38 -> 1.3.40 won't break because you need newer version of JDK

thank you for considering these ^

@thebehera
Copy link
Contributor

Hey I completely agree with you on this. I was attempting to update several components and it appears i might have unintentionally updated the java version. I will look in to correcting this.

For github release tagging, yes I am looking into automating this if possible however I have to research this. Thanks for the suggestion and I agree it's hard to track the releases with the current process

As for the semvar stuff, yes I agree and this shouldn't happen in the future. thanks!

@thebehera
Copy link
Contributor

@jbruchanov Will #66 fix your jvmTarget issues?

@jbruchanov
Copy link
Author

@jbruchanov Will #66 fix your jvmTarget issues?

awesome, yes it did help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants