Leaving Discord Messenger open for a while causes images and menu entries to stop being displayed

[Zero3K]

[iProgramMC]

Looks like bitmaps are being invalidated. The fix for now is to restart the app but this should really be fixed.

[Zero3K]

I wonder why the menu items are also not showing up when the bitmaps stop showing up.

[iProgramMC]

What menu items?

[Zero3K]

All of them.

[iProgramMC]

All of them is too vague. Show screenshots of exactly what you are talking about. What menu you are talking about, and what specific items.

[Zero3K]

I think it is a GDI Handle leak according to this:

That number keeps going up every few seconds.

Here's a more through look into what is leaking:

The number of Bitmaps is increasing.

[iProgramMC]

Every few seconds is a bit strange.

Also, how many hours of browsing do you typically get before running into this issue?

[Zero3K]

I'll reply when it happens again with how long it took to happen.

[Zero3K]

It took around 2 hours and 40 minutes for it to happen. The GDI Handle count stopped being counted at 9,999.

[iProgramMC]

I see.

[iProgramMC]

Fixed in upstream. It turns out there is an issue with the guild list control. It didn't free the result to LoadBitmap().

[Zero3K]

There's still another leak that is happening.

[iProgramMC]

As far as I know, I've fixed all known leaks. I've tried dragging the window continuously outside of the screen and it doesn't increase the GDI object/handle counter too much.

A tip I can give you to track down the leak is to open it up in Windows XP (or Windows 7 with the basic theme), drag a window over it and slowly reveal every control in the app. That's how I started noticing that the guild list is leaking GDI objects.

[Zero3K]

Then I wonder why the GDI Handles went up to 9,999 when I left it alone for a while.

[iProgramMC]

I gave you a way to debug it.

[Zero3K]

I did that and see that the Bitmap number is still going up (but not as quickly).

[iProgramMC]

OK, I've fixed another handle leak. It should be fine now!

It was due to leftover code that loaded some bitmaps uselessly everytime the member list was updated. Apparently LR_SHARED as parameter inside LoadImage only takes effect if the bitmap is of a standard size, which the status icons aren't. (They're 36x36)