Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the ergonomics and security of ServerFnError #3243

Open
ryo33 opened this issue Nov 20, 2024 · 0 comments
Open

Enhance the ergonomics and security of ServerFnError #3243

ryo33 opened this issue Nov 20, 2024 · 0 comments
Labels
enhancement New feature or request fullstack related to the fullstack crate

Comments

@ryo33
Copy link

ryo33 commented Nov 20, 2024

Problems

  • Any ? operator in the server function might inadvertently expose sensitive error messages from the server side because the From is implemented for ServerFnError which uses error.to_string().
  • Functions that return anyhow::Error are cumbersome to use because they need explicit conversion (e.g., using the server_fn_error! macro).
  • It's difficult to share structured error types between server and client because ServerFnError has its own serialization strategy utilizing FromStr and Display.

Feature Request

Allow users to specify any error type for the server fn result where E: Serialize + DeserializeOwned + From<ServerFnError> + Debug + Display + Error. This could also require AsRef<ServerFnError> if Dioxus internally needs to identify the error kind on the client side. Since the ServerFnError itself satisfies these bounds, this change would be backward-compatible with the existing signature. However, I'd like to remove the ServerFnError::WrappedServerError and the corresponding generics field from it.

This feature would give users full control over From, Serialize, and Deserialize implementations for their error types and addresses the issues outlined above.

Implement Suggestion

Fork the server_fn_macro into the packages/server_macro and customize it as necessary.

Questions

  • Is there a strong rationale for continuing to use Leptos's server_fn_macro, or would maintaining a Dioxus-specific macro be more beneficial?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fullstack related to the fullstack crate
Projects
None yet
Development

No branches or pull requests

2 participants