Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained actions-rs actions #1360

Closed
esimkowitz opened this issue Aug 15, 2023 · 2 comments
Closed

Replace unmaintained actions-rs actions #1360

esimkowitz opened this issue Aug 15, 2023 · 2 comments
Labels
ci github ci

Comments

@esimkowitz
Copy link
Contributor

esimkowitz commented Aug 15, 2023

Specific Demand

actions-rs/toolchain and the rest of the actions-rs org have been unmaintained for over two years. See this Reddit thread for more info. I'm also tagging the issue of shame. We should update the pipelines to use a different approach for installing Rust toolchains.

Implement Suggestion

One that keeps coming up in the forums as a good replacement is dtolnay/rust-toolchain. I've successfully integrated this in my personal project and in my PR #1358 for the new CLI release pipeline. I think this is a good move for the other pipelines in this project to avoid any vulnerabilities or disruptions (such as the eventual set-output deprecation).

@ealmloff ealmloff added the ci github ci label Aug 15, 2023
@esimkowitz esimkowitz changed the title Replace unmaintained actions-rs/toolchain action Replace unmaintained actions-rs actions Aug 15, 2023
@ealmloff
Copy link
Member

Closed by #1366

@striezel
Copy link
Contributor

Just for laughs take a look at #1099.

So the issue described here was already fixed in #1099 on June 19th, but both actions-rs/toolchain and actions-rs/cargo were re-introduced in #1222 on July 20th, a month later. PR #1222 was also merged by its creator without review, so you might possibly want to put some checks in place to avoid that in the future. Otherwise you might see yourselves in the position where you need to address this very issue again.

(And then there is #1077 which also uses / re-introduced the unmaintained actions-rs stuff, but since the issue was created before #1099 and was only merged after #1099 one cannot really blame its creator. It's just an unfortunate chain of events. Had it been merged before #1099, then #1099 would have picked that up.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci github ci
Projects
None yet
Development

No branches or pull requests

3 participants