Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta http_equiv instead of http-equiv #1268

Closed
paul2t opened this issue Jul 30, 2023 · 3 comments · Fixed by #1277
Closed

meta http_equiv instead of http-equiv #1268

paul2t opened this issue Jul 30, 2023 · 3 comments · Fixed by #1277
Labels
bug Something isn't working good first issue Good for newcomers html Related to the html crate

Comments

@paul2t
Copy link

paul2t commented Jul 30, 2023

When rendering this:
meta { http_equiv: "X-UA-Compatible", content: "IE=edge" }
We get this in html: <meta http_equiv="X-UA-Compatible" content="IE=edge">
It should be http-equiv instead of http_equiv.

Steps To Reproduce

Steps to reproduce the behavior:
Create a component with this code:
cx.render(rsx!(meta { http_equiv: "X-UA-Compatible", content: "IE=edge" }))

Expecting http-equiv instead of http_equiv.

https://www.w3schools.com/tags/att_meta_http_equiv.asp

Environment:

  • Dioxus version: v0.3.2 (also using dioxus-ssr v0.3.0)
  • Rust version: 1.71.0 stable
  • OS info: Windows
  • App platform: web
@ealmloff ealmloff added bug Something isn't working html Related to the html crate labels Jul 31, 2023
@ealmloff
Copy link
Member

To fix this issue, we need to change this line to output "http-equiv" instead of DEFAULT. (example of renaming the output)

@ChrisCA
Copy link
Contributor

ChrisCA commented Aug 2, 2023

When creating the fix for that issue, the code looks like its been generated, if I'm not mistaken.
I'm curious, Is there a mechanism to ensure, that if the generating process is updated, this fix doesn't get overwritten?
In example a place we we would test the http_equiv against actually generating the http-equiv output?

@ealmloff
Copy link
Member

ealmloff commented Aug 2, 2023

When creating the fix for that issue, the code looks like its been generated, if I'm not mistaken. I'm curious, Is there a mechanism to ensure, that if the generating process is updated, this fix doesn't get overwritten? In example a place we we would test the http_equiv against actually generating the http-equiv output?

The code is not auto generated, just built up over time and copied from various sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers html Related to the html crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants