Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make twitter payload adhere the spec #198 #430

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Make twitter payload adhere the spec #198 #430

merged 1 commit into from
Nov 27, 2019

Conversation

guanbinrui
Copy link
Member

close #428

neruthes
neruthes reviewed Nov 27, 2019
View reviewed changes
src/social-network-provider/twitter.com/encoding.ts
r = batchReplace(r, [
payload = batchReplace(payload, [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase bytes used

neruthes
neruthes approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@neruthes neruthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guanbinrui guanbinrui merged commit f2109a9 into release/1.8.0-rc.1 Nov 27, 2019
@guanbinrui guanbinrui deleted the hotfix/428 branch November 27, 2019 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neruthes neruthes neruthes approved these changes

@Jack-Works Jack-Works Awaiting requested review from Jack-Works

@SunriseFox SunriseFox Awaiting requested review from SunriseFox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guanbinrui @neruthes