twitter support, finalizing #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this stage 5? |
|
|
Yes and this stage will not introduce new feature.. |
Misaka-0x447f
force-pushed
the
feat/twitter-finalizing
branch
from
254ae21
to
98de491
Compare
|
What's up here? |
|
this branch was automatically closed by github. |
Misaka-0x447f
force-pushed
the
feat/twitter-finalizing
branch
from
40c4334
to
d81f291
Compare
Misaka-0x447f
force-pushed
the
feat/twitter-finalizing
branch
from
d00c57a
to
99cd0bb
Compare
Jack-Works
reviewed
Nov 1, 2019
Jack-Works
reviewed
Nov 1, 2019
Jack-Works
reviewed
Nov 1, 2019
Jack-Works
reviewed
Nov 1, 2019
Jack-Works
reviewed
Nov 1, 2019
Jack-Works
reviewed
Nov 1, 2019
|
|
||
| export const untilElementAvailable = async (ls: LiveSelector<HTMLElement, boolean>) => { | ||
| await timeout(new MutationObserverWatcher(ls).startWatch({ childList: true, subtree: true }).then(), 10000) | ||
| return new Promise<void>((resolve, reject) => { |
There was a problem hiding this comment.
why change to this way to impl?
and we have a IntervalWatcher in holoflows/kit
There was a problem hiding this comment.
the prev implement was not working. maybe delay fixing?
Jack-Works
reviewed
Nov 1, 2019
Jack-Works
approved these changes
Nov 5, 2019
SunriseFox
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delayed to stage LTE:
[?] show welcome not detecting if current user has been setup (#193)
[?] use random website as prefix (#198)
[?] fetchPostContent (facebook) not working properly (#323)
*LTE: Long term evolution