Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deconstruct undefined #11158

Merged
merged 4 commits into from
Nov 22, 2023
Merged

fix: deconstruct undefined #11158

merged 4 commits into from
Nov 22, 2023

Conversation

guanbinrui
Copy link
Member

@guanbinrui guanbinrui commented Nov 22, 2023

Description

Closes #10919
Closes #10826
Closes MF-0000

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

@guanbinrui guanbinrui added this to the 2.23.12 milestone Nov 22, 2023
@guanbinrui guanbinrui changed the base branch from develop to released November 22, 2023 09:01
@github-actions github-actions bot temporarily deployed to pull request November 22, 2023 09:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 22, 2023 09:11 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 22, 2023 09:19 Inactive
@guanbinrui guanbinrui marked this pull request as ready for review November 22, 2023 09:23
@guanbinrui guanbinrui merged commit 17b7ef8 into released Nov 22, 2023
15 of 16 checks passed
@guanbinrui guanbinrui deleted the fix/destruct-undefined branch November 22, 2023 09:27
@guanbinrui guanbinrui restored the fix/destruct-undefined branch November 22, 2023 09:28
@guanbinrui guanbinrui deleted the fix/destruct-undefined branch December 26, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant