Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Encryption UX cannot deal with nested comment/reply #101

Closed
Tedko opened this issue Aug 10, 2019 · 3 comments · Fixed by #384
Closed

Comment Encryption UX cannot deal with nested comment/reply #101

Tedko opened this issue Aug 10, 2019 · 3 comments · Fixed by #384
Assignees
@Jack-Works @SunriseFox
Labels
Blocked: Local Kind: UI-Injected Network: facebook.com Platform: Web browser Chrome-like and Firefox (WebExtension) Priority: P3 (Normal) Severity: High The issue reports incorrect functionality, bad functionality, a confusing user experience, etc.

Comments

@Tedko
Copy link
Member

Tedko commented Aug 10, 2019 •
edited
Loading

Screen Shot 2019-08-10 at 13 16 27

Screen Shot 2019-08-10 at 13 16 55

Another bug:

Screen Shot 2019-08-10 at 13 20 25

See the pictures above.
For the 1st 2 pics: Easy to reproduce if you are trying to write comment with nested comments. Only one of the comment box with display the 'encryption comment box'.
For the last pics: Click 'reply' on someone and then type sth in the 'encryption comment box' and post it, it will display like that.

Potential fix:

  • Display multiple 'encryption comment box'
@Tedko Tedko added Type: Bug Priority: P1 (Now) P1 Platform: Web browser Chrome-like and Firefox (WebExtension) Severity: High The issue reports incorrect functionality, bad functionality, a confusing user experience, etc. Network: facebook.com labels Aug 10, 2019
@Jack-Works Jack-Works added the Design Limitation Constraints of the existing architecture prevent this from being fixed label Aug 22, 2019
@Jack-Works
Copy link
Member

Design limitation. Not easy to support multiple comment box for one post

@Tedko
Copy link
Member Author

Tedko commented Aug 22, 2019 via email

@neruthes
Copy link
Contributor

neruthes commented Nov 7, 2019

Any update?

@SunriseFox SunriseFox added Priority: P5 (Plan in future) We have a plan to do this in future. and removed Priority: P1 (Now) P1 labels Nov 7, 2019
SunriseFox pushed a commit that referenced this issue Nov 11, 2019
fix: only insert one comment box per post (#101)
3f2309c
@SunriseFox SunriseFox mentioned this issue Nov 11, 2019
Merged
@Tedko Tedko added Priority: P3 (Normal) and removed Priority: P5 (Plan in future) We have a plan to do this in future. labels Nov 12, 2019
SunriseFox pushed a commit that referenced this issue Nov 13, 2019
fix: only insert one comment box per post (#101)
a87d637
SunriseFox pushed a commit that referenced this issue Nov 13, 2019
fix: only insert one comment box per post (#101)
e0b028d
Jack-Works pushed a commit that referenced this issue Nov 27, 2019
@Jack-Works
fix: only insert one comment box per post (#101)
13943d2
@neruthes neruthes added Blocked: Local and removed Design Limitation Constraints of the existing architecture prevent this from being fixed labels Feb 10, 2020
lucasespinosa28 pushed a commit to lucasespinosa28/Maskbook that referenced this issue Dec 13, 2021
@austintgriffith
Merge pull request DimensionDev#101 from ironsoul0/master
84d5fd5 
feat: add faucetAvailable boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jack-Works Jack-Works

@SunriseFox SunriseFox

Labels
Blocked: Local Kind: UI-Injected Network: facebook.com Platform: Web browser Chrome-like and Firefox (WebExtension) Priority: P3 (Normal) Severity: High The issue reports incorrect functionality, bad functionality, a confusing user experience, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only insert one comment box per post (#101) DimensionDev/Maskbook
4 participants
@neruthes @Jack-Works @Tedko @SunriseFox