Resolve some TODOs

src/_locales/en/messages.json

@@ -197,6 +197,9 @@
     "banner_title": {
         "message": "Welcome to Maskbook"
     },
+    "banner_collecting_identity": {
+        "message": "Maskbook is identifying how to setup your account..."
+    },
     "banner_get_started": {
         "message": "Get started"
     },

src/_locales/zh/messages.json

@@ -198,6 +198,9 @@
     "banner_title": {
         "message": "歡迎使用 Maskbook"
     },
+    "banner_collecting_identity": {
+        "message": "Maskbook 正在準備向導過程……"
+    },
     "banner_get_started": {
         "message": "開始使用"
     },

src/components/InjectedComponents/AdditionalPostContent.tsx

@@ -7,11 +7,7 @@ interface Props {
     children?: any
 }
 const useStyles = makeStyles({
-    upDivider: {
-        marginBottom: 6,
-        // TODO: ? is this useful?
-        marginBlock: 6,
-    },
+    upDivider: { marginBottom: 6 },
     title: { display: 'flex' },
     icon: { transform: 'translate(-1px, -1px)' },
     content: {

src/components/Welcomes/Banner.tsx

@@ -34,10 +34,7 @@ export function Banner(props: Props) {
             <Toolbar className={classes.toolbar}>
                 <Box flex={1}>
                     <Typography variant="subtitle1" color="inherit">
-                        {/* // TODO: i18n */}
-                        {props.disabled
-                            ? "Sorry, you can't setup your maskbook account currently, please try again later"
-                            : geti18nString('banner_title')}
+                        {props.disabled ? geti18nString('banner_collecting_identity') : geti18nString('banner_title')}
                     </Typography>
                 </Box>
                 <Button

src/database/migrate/old.keystore.1.ts

@@ -78,7 +78,6 @@ export default async function migrate() {
     const wait = (await queryPeopleCryptoKey()).map(record => {
         if (record.username === '$self')
             return People.storeMyIdentityDB({
-                // TODO: Need to update later !
                 identifier: new PersonIdentifier('facebook.com', '$self'),
                 groups: [],
                 publicKey: record.publicKey,

src/database/people.ts

@@ -21,6 +21,7 @@
 import { PersonIdentifier, Identifier, GroupIdentifier } from './type'
 import { openDB, DBSchema } from 'idb/with-async-ittr'
 import { JsonWebKeyToCryptoKey, CryptoKeyToJsonWebKey } from '../utils/type-transform/CryptoKey-JsonWebKey'
+import { sendNewPersonMessageDB } from '../utils/messages'
 
 //#region Type and utils
 /**
@@ -117,7 +118,7 @@ const db = openDB<PeopleDB>('maskbook-people-v2', 1, {
 export async function storeNewPersonDB(record: PersonRecord): Promise<void> {
     const t = (await db).transaction('people', 'readwrite')
     await t.objectStore('people').put(await toDb(record))
-    // TODO: Send new person message
+    sendNewPersonMessageDB(record)
     return
 }
 /**
@@ -163,8 +164,8 @@ export async function updatePersonDB(person: Partial<PersonRecord> & Pick<Person
     const full = await t.objectStore('people').get(person.identifier.toText())
     if (!full) throw new Error('Person is not in the db')
     const o: PersonRecordInDatabase = { ...full, ...(await toDb(person as PersonRecord)) }
-    // TODO: Send new person message
     await t.objectStore('people').put(o)
+    sendNewPersonMessageDB(await outDb(o))
 }
 /**
  * Remove people from database

src/extension/background-script/CryptoService.ts

@@ -1,6 +1,5 @@
 import * as Alpha40 from '../../crypto/crypto-alpha-40'
 import { OnlyRunInContext } from '@holoflows/kit/es'
-import { addPersonPublicKey } from '../../key-management/people-gun'
 import { publishPostAESKey as publishPostAESKey_Service, queryPostAESKey } from '../../key-management/posts-gun'
 
 import { decodeText, encodeArrayBuffer, decodeArrayBuffer } from '../../utils/type-transform/String-ArrayBuffer'
@@ -10,7 +9,8 @@ import { toCompressSecp256k1Point, unCompressSecp256k1Point } from '../../utils/
 import { Person, getMyPrivateKeyAtFacebook, queryPerson } from '../../database'
 import { queryMyIdentityAtDB, storeNewPersonDB, queryPersonDB, queryLocalKeyDB } from '../../database/people'
 import { PersonIdentifier } from '../../database/type'
-import { gun } from '../../key-management/gun'
+import { addPersonPublicKey } from '../../key-management/people-gun'
+import { gun } from '../../network/gun/version.1'
 
 OnlyRunInContext('background', 'EncryptService')
 //#region Encrypt & Decrypt

src/key-management/people-gun.ts

@@ -1,11 +1,11 @@
-import { gun } from './gun'
 import tasks from '../extension/content-script/tasks'
 import { verifyOthersProve } from '../extension/background-script/CryptoService'
 import { sleep } from '../utils/utils'
 import { getProfilePageUrlAtFacebook, getPostUrlAtFacebook } from '../utils/type-transform/Username'
 import { geti18nString } from '../utils/i18n'
 import { PersonIdentifier, PostIdentifier, PersonUI } from '../database/type'
 import { queryPerson } from '../database'
+import { gun } from '../network/gun/version.1'
 
 export async function queryPersonFromGun(username: string) {
     return gun

src/key-management/posts-gun.ts

@@ -1,6 +1,6 @@
-import { gun } from './gun'
 import { PublishedAESKey } from '../crypto/crypto-alpha-40'
 import { OnlyRunInContext } from '@holoflows/kit/es'
+import { gun } from '../network/gun/version.1'
 
 OnlyRunInContext('background', 'gun')
 /**

src/network/gun/version.1.ts

@@ -1,3 +1,6 @@
+import Gun from 'gun'
+import 'gun/lib/then'
+import { OnlyRunInContext } from '@holoflows/kit/es'
 import { PublishedAESKey } from '../../crypto/crypto-alpha-40'
 
 export interface ApplicationStateInGunVersion1 {
@@ -11,10 +14,14 @@ export interface ApplicationStateInGunVersion1 {
         posts: {
             // Post id or salt
             [postIdentifier: string]: {
-                // TODO: This will leak post targets. (But keys are safe
-                // TODO: Consider using hash(id+username) or something
+                // NON-TODO: This will leak post targets. (But keys are safe
+                // NON-TODO: Consider using hash(id+username) or something
+                // ? Resolved in version -40. But not implemented yet.
                 [receiversUsername: string]: PublishedAESKey
             }
         }
     }
 }
+OnlyRunInContext('background', 'Gun')
+interface State extends ApplicationStateInGunVersion1 {}
+export const gun = new Gun<State>(['http://172.104.123.119:8765/gun']).get('maskbook')

src/utils/jss/ConstructableStyleSheetsRenderer.ts

@@ -424,7 +424,6 @@ export default class ConstructableStyleSheetsRenderer {
 
         // When rules are inserted using `insertRule` API, after `sheet.detach().attach()`
         // browsers remove those rules.
-        // TODO figure out if its a bug and if it is known.
         // Workaround is to redeploy the sheet.
         if (this.hasInsertedRules) {
             this.hasInsertedRules = false

src/utils/messages.ts

@@ -1,5 +1,6 @@
-import { MessageCenter as MC } from '@holoflows/kit/es'
-import { Person } from '../database'
+import { MessageCenter as MC, OnlyRunInContext } from '@holoflows/kit/es'
+import { Person, personRecordToPerson } from '../database'
+import { PersonRecord } from '../database/people'
 
 interface UIEvent {}
 interface KeyStoreEvent {
@@ -8,4 +9,8 @@ interface KeyStoreEvent {
 interface TypedMessages extends UIEvent, KeyStoreEvent {}
 
 export const MessageCenter = new MC<TypedMessages>('maskbook-events')
+export async function sendNewPersonMessageDB(personRecord: PersonRecord) {
+    OnlyRunInContext(['background', 'debugging'], 'sendNewPersonDB')
+    MessageCenter.send('newPerson', await personRecordToPerson(personRecord))
+}
 MessageCenter.writeToConsole = true

src/utils/type-transform/Username.ts

@@ -31,7 +31,6 @@ export function getPostUrlAtFacebook(post: PostIdentifier<PersonIdentifier>) {
  * Normalize profile url
  */
 export function getProfilePageUrlAtFacebook(user: PersonIdentifier | GroupIdentifier) {
-    // TODO:
     if (user instanceof GroupIdentifier) throw new Error('Not implemented')
     if (user.network !== 'facebook.com') throw new Error('Not implemented')
     const username = user.userId