Update 1a2 image; Somehow imporve aria

DimensionDev · Apr 21, 2019 · 2e8cac3 · 2e8cac3
1 parent c14d424
commit 2e8cac3
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 5 deletions.
diff --git a/src/components/InjectedComponents/AdditionalPostContent.tsx b/src/components/InjectedComponents/AdditionalPostContent.tsx
@@ -33,7 +33,7 @@ export const AdditionalContent = withStylesTyped({
         <>
             <Divider className={classes.upDivider} />
             <Typography variant="caption" className={classes.title}>
-                <img src={icon} className={classes.icon} />
+                <img alt="Logo of Maskbook" src={icon} className={classes.icon} />
                 {props.title}
             </Typography>
             <Typography variant="body1" className={classes.content}>

diff --git a/src/components/InjectedComponents/SelectPeopleDialog.tsx b/src/components/InjectedComponents/SelectPeopleDialog.tsx
@@ -43,7 +43,9 @@ export const SelectPeopleDialog = withStylesTyped({
                     Cancel
                 </Button>
                 <Button size="large" disabled={committed || people.length === 0} color="primary" onClick={share}>
-                    {committed && <CircularProgress className={classes.progress} size={16} variant="indeterminate" />}
+                    {committed && (
+                        <CircularProgress aria-busy className={classes.progress} size={16} variant="indeterminate" />
+                    )}
                     {committed ? 'Sharing' : 'Share'}
                 </Button>
             </DialogActions>

diff --git a/src/components/Welcomes/1a2.jpg b/src/components/Welcomes/1a2.jpg
diff --git a/src/components/Welcomes/1a2.tsx b/src/components/Welcomes/1a2.tsx
@@ -32,7 +32,12 @@ export default withStylesTyped(theme =>
     return (
         <Paper className={classes.paper}>
             <Typography variant="h5">Encrypt message use this postbox</Typography>
-            <img src={getUrl(require('./1a2.jpg'))} width="75%" className={classes.img} />
+            <img
+                alt="Screenshot of how to encrypt message with Maskbook"
+                src={getUrl(require('./1a2.jpg'))}
+                width="75%"
+                className={classes.img}
+            />
             <Typography variant="subtitle1">
                 Then only people you selected with Maskbook can see the post content
             </Typography>

diff --git a/src/components/Welcomes/1a3.tsx b/src/components/Welcomes/1a3.tsx
@@ -31,7 +31,7 @@ export default withStylesTyped(theme =>
     return (
         <Paper className={classes.paper}>
             <Typography variant="h5">Keep your backups carefully</Typography>
-            <img src={getUrl(require('./1a3.jpg'))} width="auto" height={160} />
+            <img alt="" src={getUrl(require('./1a3.jpg'))} width="auto" height={160} />
             <Typography variant="caption">{filename}</Typography>
             <Typography variant="subtitle1">
                 The first backup has been put in your Downloads folder.

diff --git a/src/components/Welcomes/Banner.tsx b/src/components/Welcomes/Banner.tsx
@@ -45,7 +45,10 @@ export const Banner = withStylesTyped({
                     color="primary">
                     Get started
                 </Button>
-                <IconButton onClick={props.close} classes={{ root: props.classes.close }} aria-label="Close">
+                <IconButton
+                    aria-label="Dismiss the banner"
+                    onClick={props.close}
+                    classes={{ root: props.classes.close }}>
                     <CloseIcon />
                 </IconButton>
             </Toolbar>