Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Talk] Do we need to use typography? #51

Open
zhouhanseng opened this issue Aug 18, 2020 · 2 comments
Open

[Talk] Do we need to use typography? #51

zhouhanseng opened this issue Aug 18, 2020 · 2 comments

Comments

@zhouhanseng
Copy link

Inroduction and Background

Here DashboardRouters/Setup.tsx#L133, if I tried to replace the <Typography> with just a <p>, it renders the same ui result.

https://material-ui.com/components/typography/:

Too many type sizes and styles at once can spoil any layout. A typographic scale has a limited set of type sizes that work well together along with the layout grid.

So as we define our own font-size, font-weight and so on, I think we don't need to use typography.
@neruthes neruthes transferred this issue from DimensionDev/Maskbook Aug 18, 2020
@Jack-Works
Copy link
Member

Did you try the dark mode? IIRC <Typography> automatically fits that but <p> won't. (still in black color)

@zhouhanseng
Copy link
Author

zhouhanseng commented Aug 20, 2020 •
edited
Loading

Dark mode works well. <p> inherits the color from <body>, and even there's no inheritation, it's fine to define a color for <p>, like we do for <Typography> as well.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jack-Works @zhouhanseng