-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce flags SVG assets size #143
Comments
@G00fY2 In the release/1.13.x branch flag_rs.xml was reduced in size and I'm now seeing 212KB in 1.13.x instead of 1647KB in 1.12.x (or main). That still seems excessive for use in a thumbnail size display. (According to https://github.com/Digitaler-Impfnachweis/covpass-android/blob/main/README.md#release-policy-and-branches there may be delays in publishing the released code into the main branch and currently it is lagging behind the version 1.13.3 which has been published to the Google Play Store.) |
It should be way more efficient in size and performance to generate the flags as PNG/WebP drawables, because all the vector paths to draw the emblems are not visibile at this scale. I just run a short test to see the total size of the xxxhdpi folder for all flags in 24x24px PNG -> 218 KB |
Thanks for raising this. As you already stated we've improved the sizing in release 1.13.2 . There is still room for improvements but it's a matter of priority in comparison to other topics. We're working hard to define the best priorities. Please provide more insights when you experience performance issues with the current app version. Especially share details about your device / setup. |
Hello @G00fY2, Thank you for your contribution, this will be part of release 1.40.0 |
Currently the flag svg drawables (which are only used for 24x24px) images in the country selection view of the validity check are way to large.
Uncompressed file sizes:
Suggested Enhancement
Replace the large assets (ideally all) with a optimized SVG representations. E.g. the Serbian flag over here has the same details but the file has only 72 KB: https://github.com/hampusborgos/country-flags/blob/main/svg/rs.svg
Expected Benefits
Smaller APK size, better memory footprint and performance.
The text was updated successfully, but these errors were encountered: