Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install ctk_cli from my fork until my upstream PR gets merged #165

Merged
merged 3 commits into from
Aug 15, 2016

Conversation

cdeepakroy
Copy link
Contributor

@zachmullen This PR makes ansible install ctk_cli from my fork until my PR on the upstream repo gets merged.

@codecov-io
Copy link

codecov-io commented Aug 12, 2016

Current coverage is 36.32% (diff: 100%)

Merging #165 into master will not change coverage

@@             master       #165   diff @@
==========================================
  Files            22         22          
  Lines          1437       1437          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            522        522          
  Misses          915        915          
  Partials          0          0          

Powered by Codecov. Last update fda9438...298bd5c

@@ -64,7 +64,7 @@

- name: Clone ctk-cli
git:
repo: git://github.com/commontk/ctk-cli.git
repo: git@github.com:cdeepakroy/ctk-cli.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you are using git@ rather than git://? It didn't work for me this way (but it does when I switch to the git:// format).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will change it.

@@ -64,10 +64,9 @@

- name: Clone ctk-cli
git:
repo: git://github.com/commontk/ctk-cli.git
repo: git://github.com:cdeepakroy/ctk-cli.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be git://github.com/cdeepakroy/ctk-cli.git (slash, not colon after github.com).

@manthey
Copy link
Contributor

manthey commented Aug 15, 2016

LGTM

@cdeepakroy cdeepakroy merged commit 639dd9e into master Aug 15, 2016
@cdeepakroy cdeepakroy deleted the fix_ansible_ctk_cli branch September 6, 2016 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants