Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt sea-map run-scripts for npm v7+ #143

Closed
wu-lee opened this issue Feb 7, 2022 · 3 comments
Closed

adapt sea-map run-scripts for npm v7+ #143

wu-lee opened this issue Feb 7, 2022 · 3 comments

Comments

@wu-lee
Copy link
Contributor

wu-lee commented Feb 7, 2022

The NPM maintainers, in their wisdom, have decided to remove a feature we use in our run-scripts for building and deploying. As such, we can't use versions of NPM newer than 6 (7 or higher) until we find a way around this missing feature.

See:
npm/cli#2452 (comment)
npm/rfcs#305

wu-lee pushed a commit that referenced this issue Feb 9, 2022
We support npm v6, but not yet v7+, see #143.

As such, v5 expects package-lock.json v1.
@ColmMassey
Copy link
Contributor

When might we need to address this? @wu-lee

@wu-lee
Copy link
Contributor Author

wu-lee commented Nov 8, 2022

I've needed to bump the version of node in use to a recent one (16.*, i.e. lts/gallium) in order to get an implementation of Promise.all, used in the sparql-bypass feature to await several asynchronous download operations in parallel.

Therefore, I've run into this problem again. But this time I've found a work-around: use npm config get [..] to obtain the config value from .npmrc and then set the appropriate environment variable, in the bin/sea-site-build script.

Fix applied in 4d90200

@wu-lee wu-lee closed this as completed Nov 8, 2022
@wu-lee
Copy link
Contributor Author

wu-lee commented Nov 16, 2022

Oh, the map apps will also need to use a deploy script included in mykomap, that works around the problem. But then to use mykomap they will need various alterations along with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants