Rosetta SDK: Initial Draft Implementation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot an application
… default configuration file
…they extracted the model name wrong and accessed the schema incorrectly.
the other is a skeleton for a basic Rosetta Server Implementation.
|
@SmartArray , can we close this PR out in favor of the newer one? |
gto90
requested changes
Aug 24, 2020
examples/server/index.js
Outdated
| }); | ||
|
|
||
| Server.launch() | ||
| .catch(e => logger.error(e)); |
There was a problem hiding this comment.
Can you add a new line here? I'll take a look at the project structure but we should be using ES Lint with Semistandard rules. Most IDEs would catch this as a result and offer to automatically fix them.
|
|
||
| RosettaSyncerEvents, | ||
| Errors, | ||
| }; |
There was a problem hiding this comment.
Same here @SmartArray , We'll want to use something like ES Lint to fix all this up automatically.
There was a problem hiding this comment.
Thought I was using ESLint, but let me double check.
Kk, let us close all the PRs. Will do one for every version. Please create a branch 1.3.1 and 1.4.1 so I can PR against them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR contains an initial draft implementation for Coinbase's official Rosetta Spec, written in NodeJS/Javascript.
State of this implementation
The state of this implementation is still an early alpha. All components have been ported from the official Go reference implementation to maintain 100% compatibility.
At the moment: the following unit tests have been ported to this implementation:
Additional Remarks
We have used the official OpenAPI NodeJS Express Generator to generate the server stub.
Furthermore, the Client Module was generated with the OpenAPI Javascript Generator. This generator was executed twice to have one promised version, and one with callbacks. They have also generated type classes, which are located in
lib/client/src/model. These may be exported to another separate module in the future.Documentation has been added for Fetcher Module only. See
lib/fetcher/README.md.