Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge providers from Bazarr #1078

Open
getzze opened this issue May 13, 2024 · 3 comments
Open

Merge providers from Bazarr #1078

getzze opened this issue May 13, 2024 · 3 comments

Comments

@getzze
Copy link
Collaborator

getzze commented May 13, 2024

They seem to maintain a long list of providers:
https://github.com/morpheus65535/bazarr/tree/master/libs/subliminal_patch/providers

@getzze getzze changed the title Merges providers from Bazarr Merge providers from Bazarr May 13, 2024
@ptrcnull
Copy link
Collaborator

that's not gonna be possible, unless all their contributors relicense their contributions under MIT ( which Subliminal uses )

@getzze
Copy link
Collaborator Author

getzze commented May 16, 2024

ah yes... Then we will have to revive old PRs here :)

@getzze
Copy link
Collaborator Author

getzze commented May 29, 2024

I was thinking what was the best way to include other providers and I think it makes sense to create a subliminal-providers package with the other providers, only keeping key providers in this package.
Like that subliminal-providers could have another release schedule and a faster review process, keeping subliminal "clean".

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants