Cargo clippy with cargo-sysroot warns on sysroot

[XAMPPRocky]

Hey while working on EmbarkStudios/rust-gpu#239 I noticed that when running cargo clippy on a project that uses cargo-sysroot in a build script will also run clippy on core, which isn't ideal since there's a lot of warnings, and there's not much I as a user can do about it. It would be nice if clippy didn't warn about sysroot.

[DianaNites]

Gonna need more information here, as i'm unable to reproduce, and have never had that happen before.

[XAMPPRocky]

Here's steps to reproduce. I'm running on macOS 11.0.1

1. Clone & Checkout https://github.com/EmbarkStudios/rust-gpu/tree/vuild-system
2. Run cargo clippy --manifest-path examples/runners/ash/Cargo.toml -vv

You can also see the output here, as I first noticed on CI. https://github.com/EmbarkStudios/rust-gpu/runs/1418118000?check_suite_focus=true#step:8:333

[DianaNites]

Does not reproduce on my machine, clippy ran successfully.

For reference I'm on Arch Linux, if that makes any difference.

[XAMPPRocky]

Hmm, okay. I can reproduce it here, so I'll try to debug this later this week.

[DianaNites]

Apologies, seems I out the branch wrong. I'm getting failures, but nothing mentioning core, "Error loading target specification: Could not find specification for target "spirv-unknown-unknown"".
A bunch of warnings for other dependencies under ~/.cargo/registry, though?

[XAMPPRocky]

"Error loading target specification: Could not find specification for target "spirv-unknown-unknown"".

That's actually a different bug, the rustc flags in the builder aren't working.

[DianaNites]

Yeah oops, I noticed that. Fixed in 48f811f

[DianaNites]

Now it seems to be linker errors

librustc_codegen_spirv.so: undefined symbol: _ZN8spvtools3val8Function13current_blockEv"

[XAMPPRocky]

I have a fix for that locally one moment.

[XAMPPRocky]

@DianaNites Okay it's working now so running cargo clippy --manifest-path examples/runners/ash/Cargo.toml -vv (I recommend trying to compile without -vv once, to remove most of the noise) in the vuild-system branch should show clippy warnings in the example-ash build script.

[DianaNites]

Clippy now successfully runs, and i'm not seeing any clippy warnings from the sysroot, just all the dependencies?

[DianaNites]

Ah build output, If I insert a panic into the build script I see non-fatal clippy warnings.

No idea why thats happening..

[XAMPPRocky]

I’ll investigate more tomorrow, but I would hazard to guess it’s something with flags and or cargo rustc causing issues.

[XAMPPRocky]

Potnentially related: EmbarkStudios/rust-gpu#294

[DianaNites]

Cause is probably the new RUSTC_WORKSPACE_WRAPPER, documented on nightly https://doc.rust-lang.org/nightly/cargo/reference/environment-variables.html, added specifically for clippy

Removing it from the env should probably fix it

[DianaNites]

Should be fixed now but I can't test so