-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace APISchema Serialization with Pydantic 1.0 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 94.97% 94.50% -0.48%
==========================================
Files 44 44
Lines 1294 1292 -2
==========================================
- Hits 1229 1221 -8
- Misses 65 71 +6
|
…or deserialisation
DiamondJoseph
commented
Jul 14, 2023
DiamondJoseph
commented
Jul 14, 2023
DiamondJoseph
commented
Jul 14, 2023
DiamondJoseph
added a commit
to DiamondLightSource/tickit-devices
that referenced
this pull request
Jul 17, 2023
tpoliaw
reviewed
Jul 18, 2023
callumforrester
requested changes
Jul 20, 2023
tpoliaw
reviewed
Jul 20, 2023
tpoliaw
approved these changes
Jul 20, 2023
callumforrester
approved these changes
Jul 20, 2023
DiamondJoseph
added a commit
to DiamondLightSource/tickit-devices
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125