Fix eiger stream data publish #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
ebcd13f
to
60fabd6
Compare
| @@ -430,5 +430,5 @@ def __init__(self, device: EigerDevice) -> None: | |||
|
|
|||
| def after_update(self) -> None: | |||
| """Updates IOC values immediately following a device update.""" | |||
| buffered_data = self.device.stream.consume_data() | |||
| self.add_message_to_stream([list(buffered_data)]) | |||
| if buffered_data := list(self.device.stream.consume_data()): | |||
There was a problem hiding this comment.
This is a good patch but I think the proper fix is in the ZMQ adapter itself, have made an issue: DiamondLightSource/tickit#196
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
60fabd6
to
fe697e2
Compare
abbiemery
approved these changes
Nov 22, 2023
|
This will need rebasing again before merging, but LGTM. |
Remove extra list nesting of eiger stream message and only add message to stream if data is not empty. Add test to ensure new behaviour.
GDYendell
force-pushed
the
fix-eiger-stream
branch
from
fe697e2
to
579905a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91