Add nplc to gui #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit means that we will no longer attempt to send messages to instruments that have never been configured / are disabled entirely.
Previously, when using the default NPLC of 50, the timeout wouldn't have been modified and the default timeout is too short. Also add tests for all NPLC setting code
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
==========================================
+ Coverage 59.16% 60.36% +1.19%
==========================================
Files 7 7
Lines 409 444 +35
==========================================
+ Hits 242 268 +26
- Misses 167 176 +9 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "NPLC" configuration item to the main GUI. Previously this value was hard-coded as "50", hence the default value.
As this was previously set during instrument initialization and was never expected to change, this PR required an unexpectedly large amount of restructuring. Main changes include:
_init_instrumentinto sub-functions, to allow re-use forset_nplc.