Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove initial_xyz and just read in the setup plan #673

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

DominicOram
Copy link
Contributor

Fixes #541

To test:

  • Confirm tests still pass

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (75bf69b) to head (ac417fb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   85.54%   85.55%   +0.01%     
==========================================
  Files         102      102              
  Lines        6909     6895      -14     
==========================================
- Hits         5910     5899      -11     
+ Misses        999      996       -3     
Components Coverage Δ
i24 SSX 69.57% <ø> (ø)
hyperion 96.92% <100.00%> (+0.07%) ⬆️
other 94.15% <ø> (ø)

Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can now also remove sample_motors as there is nothing else that uses it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove initial_xyz
2 participants