Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zocalo results multiple sources #445

Merged
merged 16 commits into from
Sep 23, 2024
Merged

Conversation

olliesilvester
Copy link
Contributor

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you might have accidentally pulled in some changes from #429

@olliesilvester olliesilvester changed the title Zocalo results mutliple sources Zocalo results multiple sources Sep 19, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (7e3eac5) to head (49d103f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...yperion/external_interaction/callbacks/__main__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
+ Coverage   77.59%   77.60%   +0.01%     
==========================================
  Files          89       89              
  Lines        6700     6703       +3     
==========================================
+ Hits         5199     5202       +3     
  Misses       1501     1501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DominicOram DominicOram merged commit d18abf7 into main Sep 23, 2024
17 of 18 checks passed
@DominicOram DominicOram deleted the zocalo_results_mutliple_sources branch September 23, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare ZocaloResults to use multiple results sources
2 participants