Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long running tests #662

Open
DominicOram opened this issue Nov 19, 2024 · 0 comments
Open

Fix long running tests #662

DominicOram opened this issue Nov 19, 2024 · 0 comments

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Nov 19, 2024

We currently have 3 tests that are taking >>0.5s:

5.01s call     tests/unit_tests/beamlines/i24/serial/test_write_nexus.py::test_call_nexgen_for_extruder
1.03s call     tests/unit_tests/hyperion/external_interaction/callbacks/test_rotation_callbacks.py::test_ispyb_reuses_dcgid_on_same_sampleID
0.75s call     tests/unit_tests/hyperion/experiment_plans/test_multi_rotation_scan_plan.py::test_full_multi_rotation_plan_nexus_files_written_correctly

This likely points to some issues in mocking in these tests.

Acceptance Criteria

  • All tests individually take less than 1s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant