Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _fake_grid_detection and use real grid detection instead #611

Open
DominicOram opened this issue Nov 4, 2024 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@DominicOram
Copy link
Contributor

In a similar issue to #479 we have some tests that are running against _fake_grid_detection. This means if we update the grid detection prod code we need to update this too and so they will inevitably get out of sync. Instead all our tests should be run against the real grid detection prod code.

Acceptance Criteria

  • _fake_grid_detection is removed
  • Tests that used it instead use production grid detection code
@DominicOram DominicOram moved this to Candidates for Next Sprint in Hyperion Nov 4, 2024
@olliesilvester olliesilvester added the good first issue Good for newcomers label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: Candidates for Next Sprint
Development

No branches or pull requests

2 participants