Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clean up all the handlers from the i24 logging configuration #609

Open
noemifrisina opened this issue Nov 4, 2024 · 0 comments
Labels
bug Something isn't working I24 serial Issues relating to ssx on I24

Comments

@noemifrisina
Copy link
Contributor

noemifrisina commented Nov 4, 2024

With the log configuration changes in #572 the logs are now getting tidied up when closing the edm, avoiding the previously seen issue on i24 of duplicated log messages. However sometimes it looks like the filehandler for the user isn't properly closed and messages start duplicating again after an edm screen restart. The plan to tidy up logging should be changed to not only remove the handlers but properly close them.

for handler in logger.handlers:
    handler.close()
logger.handlers.clear()

Acceptance Criteria

(This needs a test on the beamline)

  • There are no more repeated messages anywhere after restarting edm when testing on i24
@noemifrisina noemifrisina added bug Something isn't working I24 serial Issues relating to ssx on I24 labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I24 serial Issues relating to ssx on I24
Projects
None yet
Development

No branches or pull requests

1 participant