Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ophyd V2 devices: consider whether the current device_instantiation abstraction(s) are correct #149

Closed
Tom-Willemsen opened this issue Aug 18, 2023 · 3 comments
Labels
enhancement New feature or request low priority Not needed for production in the near future

Comments

@Tom-Willemsen
Copy link
Contributor

For example, V2 devices don't necessarily take a prefix but have the prefix as part of the name.

We could:

  • Say that all of our v2 devices take a prefix regardless, keeping consistency with v1
  • Refactor device_instantiation to still be semi-generic but build name/prefix combinations correctly for v1 or v2 as appropriate
  • Split device_instantiation into _v1 and _v2 with different behaviour.

Unclear to me exactly what is desirable.

@stan-dot
Copy link
Contributor

@coretl this is relevant to #483 and can be either incorporated, closed, or still kept as-is

@stan-dot stan-dot added enhancement New feature or request low priority Not needed for production in the near future labels Aug 19, 2024
@coretl
Copy link
Collaborator

coretl commented Aug 20, 2024

I think this can be closed as not relevant after #483

@DominicOram do you agree?

@DominicOram
Copy link
Contributor

Yh, happy to close. Tbh we won't have any v1 devices round soon anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Not needed for production in the near future
Projects
None yet
Development

No branches or pull requests

4 participants