Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamp. #651

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Conversation

Relm-Arrowny
Copy link
Contributor

@Relm-Arrowny Relm-Arrowny commented Sep 26, 2024

fix #98

Added timestamps to both uvicorn log and python logging.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.45%. Comparing base (24c7e35) to head (cd947fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/blueapi/service/main.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #651      +/-   ##
==========================================
- Coverage   92.62%   92.45%   -0.17%     
==========================================
  Files          35       35              
  Lines        1654     1657       +3     
==========================================
  Hits         1532     1532              
- Misses        122      125       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@callumforrester
Copy link
Contributor

@Relm-Arrowny should be happy following a rebase and fixing linting

@Relm-Arrowny
Copy link
Contributor Author

Relm-Arrowny commented Oct 29, 2024

@Relm-Arrowny should be happy following a rebase and fixing linting

done, please merge it when you are happy as I dont have write access to merge.

@callumforrester callumforrester merged commit 213fbb9 into DiamondLightSource:main Oct 30, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include timestamps in logs
2 participants