Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing strategy #472

Open
stan-dot opened this issue May 17, 2024 · 6 comments
Open

Testing strategy #472

stan-dot opened this issue May 17, 2024 · 6 comments
Labels
client Relates to client code dependencies Pull requests that update a dependency file python Pull requests that update Python code tests Issues around increasing test coverage/fixing tests
Milestone

Comments

@stan-dot
Copy link
Contributor

It is uncertain how much do we want to test, and also what to do about the message bus in testing. We could mocking using something like microcks .

@stan-dot stan-dot self-assigned this May 17, 2024
@stan-dot stan-dot added dependencies Pull requests that update a dependency file python Pull requests that update Python code tests Issues around increasing test coverage/fixing tests client Relates to client code labels May 17, 2024
@callumforrester
Copy link
Contributor

Finding a way to mock the message bus without writing loads of code would indeed be good!

As a general answer, and based on recent meetings including the DAQ away day, we currently have >90% coverage and I think we should aim to keep it that way. Virtually all of the GDA codebase is not covered and it shows.

If something breaks, and you raise a PR to fix, you should always have a test that reproduces the breaking case.

@stan-dot
Copy link
Contributor Author

stan-dot commented May 17, 2024

will explore with Helm

@stan-dot
Copy link
Contributor Author

$ helm install microcks microcks/microcks --version 1.7.1 --namespace microcks --set microcks.url=microcks.$(minikube ip).nip.io --set keycloak.url=keycloak.$(minikube ip).nip.io

this uses minikube and for this I'm not sure what to use

@stan-dot
Copy link
Contributor Author

docker-compose variant doesn't work either:
image

@stan-dot
Copy link
Contributor Author

the containers go up but the endpoint is not available

@stan-dot stan-dot added this to the 1.0.0 milestone May 28, 2024
@stan-dot stan-dot removed their assignment May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Relates to client code dependencies Pull requests that update a dependency file python Pull requests that update Python code tests Issues around increasing test coverage/fixing tests
Projects
None yet
Development

No branches or pull requests

2 participants