You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
Thanks a lot for this component, it saved me a lot of work!
I'm using v1.3 and when I try to publish my new bundle, Google Play Store tells me that some devices will not be compatible with the new version, it occurs because of this library.
In the readme file you've mentioned:
<!--
If Not using Camera feature, Add following line in app manifest.
This will remove permission while manifest merge
-->
<uses-permission android:name="android.permission.CAMERA" tools:node="remove"/>
But, there's no actual need for this permission, unless of course you're presenting an embedded camera preview. If I'm not mistaking there's no embedded camera preview here, for now.
So:
Can we remove it?
We can add an option to your API that will ignore camera permissions, because when I'm using tools:node="remove" in the manifest this library simply ignores my request due to "missing permissions", which is wrong (that's the actual issue here).
However, if you like, you can use activity.packageManager.hasSystemFeature(PackageManager.FEATURE_CAMERA_ANY) to prevent camera usage when it is not available.
LMK what you think, I'll be glad to help :)
The text was updated successfully, but these errors were encountered:
@PerrchicK Thank you so much for raising this issue. I didn't know that camera permission is not required for intent. Will update the lib by tonight or max by tomorrow.
Hi,
Thanks a lot for this component, it saved me a lot of work!
I'm using v1.3 and when I try to publish my new bundle, Google Play Store tells me that some devices will not be compatible with the new version, it occurs because of this library.
In the readme file you've mentioned:
But, there's no actual need for this permission, unless of course you're presenting an embedded camera preview. If I'm not mistaking there's no embedded camera preview here, for now.
So:
tools:node="remove"
in the manifest this library simply ignores my request due to "missing permissions", which is wrong (that's the actual issue here).activity.packageManager.hasSystemFeature(PackageManager.FEATURE_CAMERA_ANY)
to prevent camera usage when it is not available.LMK what you think, I'll be glad to help :)
The text was updated successfully, but these errors were encountered: