-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with Campaign ACLs #69
Comments
Hello o/ I'm a little bit confused about what you're trying to say. According to what I just checked, the campaign you've mentioned has a disabled ACL with two channels on it, thus it should end up as "Allowed channels: All" on the inventory tab in the miner. If that's not the case, please restart the application to see if it fixes the issue. |
I see. Are you able to run the latest master branch build? |
Not initially, had to copy over my cookies, didn't realize it'd JUST broken. Yikes. Still has the issue, if you were expecting it to not be an issue. |
No, I wasn't expecting nor did / changed anything, just asking if you'd be willing to immediately try out a solution once I add it in. I can't test it myself since I can't progress that campaign. |
Gotcha gotcha, yeah I can. |
Also, at this point, I recognize it is probably not worth investigating this issue given the state of the project, so feel free to close this if that's the case. |
I'm good, as long as you have a valid cookie you can test it on. If you've ran into #68, this can also stay open until I'm able to revive this project again (hopefully). Still working on a special version for you, but I just had a working weekend, so haven't gotten enough free time to really sit on it yet. |
My testing shows that the fix I just implemented in fdd0172 registers the campaign in question as one with no ACL now: Please give the latest master a go and tell me if it fixes your issue 🙂 |
So, I'm a dumbass and accidentally finished the campaign before I could test this. However, looking over your solution, it makes sense to me, and seeing as you said you tested it, it checks out in my book. Thanks for addressing it! |
This is now fixed in |
So, I was having a similar issue to #38, and in this case, it is the Honkai Impact 3rd campaign. I investigated the "Inventory" page's query response JSON for the campaign ACLs and it is reporting the existence of an ACL; it does not specify that the ACL is disabled. However, the request being made from the "All Campaigns" tab DOES specify that it is disabled.
For reference, the request being made on the "All Campaigns" tab is using operationName "DropCampaignDetails" for each individual campaign.
I've verified that any channel playing the game with Drops Enabled is generating progress, indicating that the "Inventory" page's query response is inaccurate, while the "All Campaigns" response is accurate.
The text was updated successfully, but these errors were encountered: