Feature request - shorter wait time #175
Comments
|
Hello o/ The thing is, the 1 hour refresh cycle is quite arbitrary - campaign start and end times are tracked in real time. That means the miner will automatically reload itself when the campaign starts already, and you can verify that by monitoring closely what it does right at the campaign start time. I'd like to not lower this 1 hour to anything shorter, because whole inventory reloads are expensive network-wise and I don't want to "hammer" Twitch with requests any more often than that. Everything needed to start and track a campaign at a specific time is already implemented and should be working - if it doesn't, that's what should be investigated, not the refresh cycle time being changed. That being said, to tell what's happening, please provide the output from the miner with the CALL trace enabled, by passing in |
|
Thanks so much for responding! I didn't realize that is how things work. |
|
I see one potential issue with the drop already - the Prime Time campaign is scheduled to start at the exact same time that the first stream (warframeinternational) starts too: Could this mean that if there's a slight discrepancy (e.g. the campaign becomes active a few seconds or a minute after the stream starts), the miner would wait for an hour to retry looking for a stream with available drops? Not sure if I'm explaining this correctly, and I will keep the miner running until that stream is done and post results, but just theorizing for now. |
Not at all. Notice how the campaign lists it's ACL: In an event the channel is available already when the reload happens, the last step of the reload (channel select) should automatically start watching and progressing it. If the channel isn't immediately available, it's still added as a tracked channel (because of the ACL), and when it goes online, it'll automatically start being watched via the "channel goes online" event. Both of these situations assume that no other user condition stops it from happening, such as selecting a different channel due to the priority list, exclusion list, priority only setting, etc. There is one case that I am aware of, where the above logic can fail, but it can only happen for campaigns without an ACL, so it doesn't apply here. |
|
Here's the log from last night/this morning - again I only got 15.6% progress, because the miner only started watching at 4:59AM instead of 4:00 for some reason: 18:58:47: Logging level: CALL EDIT: just checked warframeinternational, and the stream did run for an hour plus: |
|
According to the log, a channel cleanup happened exactly at 4 AM. The cleanup should've checked the online status of all channels on the list, and subscribed to their status updates. The websocket connection would then be responsible for receiving those updates within the next hour, and if one of the channels would come online, the websocket would then generate an event that would cause a channel switch to happen and start watching as expected. But that never happened, until a reload doing another channel cleanup happened at Lines 290 to 292 in a19eceb During websocket implementation, there was an incentive on my part to create a system where this confirmation would be handled properly, but I was having trouble synchronizing the whole thing, and the websocket was simply getting stuck and preventing the program from, well, working at all. So my solution was to simply postpone this until "later" when a need for this would arise (like it does now), and until then, simply send a request for subscription and "assume" it got through properly. This thing has a related issue of #110, so when #110 is closed, this one should be closed as well, and vice versa. I'm leaving it open for anyone that possibly ends up with the same issue, so they can find the exact cause. |
|
I see - thanks for looking at this and it's great to hear that the solution is in sight! Unti this is solved, I can always just launch the browser with a task scheduler to make sure I get the drops if I really want a particular one :D |
Some game streams only last for 40 minutes to an hour and offer drops for watching for 30 minutes (Warframe is one example - they do it every week with two featured streamers after the weekly dev stream). Sometimes the stream may be longer, say, 1.5 hours, and requires watching for 40 minutes. In both cases mining often starts too late to achieve the goal and get the drop. Would it be possible to reduce the waiting time between checks from 1 hour to something shorter? Or possibly make it a custom setting?
Appreciate this wonderful program a lot, and this would make it perfect - thank you so much for making it in the first place!
EDIT: I checked the behavior in the version built from the latest source - it still persists. Warframeinternational channel is a good example - it should give one full drop per week and progress towards the next one, but it only gives some progress for the first one instead (the system is one drop for 40 minutes between that channel and official Warframe one)
The text was updated successfully, but these errors were encountered: