Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: accept module options #38

Open
koresar opened this issue Apr 3, 2019 · 3 comments
Open

Feature: accept module options #38

koresar opened this issue Apr 3, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@koresar
Copy link

koresar commented Apr 3, 2019

This doesn't work

modules: [
    ["nuxt-svg-loader", { svgoConfig: false }]
],

But this works:

modules: [ "nuxt-svg-loader" ],
svgLoader: { svgoConfig: false },

Bug or by design?
@manniL manniL added the enhancement New feature or request label Apr 3, 2019
@manniL
Copy link
Member

manniL commented Apr 3, 2019

Bug or by design?

By lazyness 😂

Accepting a PR (+tests) that takes the moduleOptions too and does correct merging if necessary. ☺️

Shouldn't be a huge thing

@koresar
Copy link
Author

koresar commented Apr 3, 2019 •
edited
Loading

I went another way. The svg-to-vue-component module now has Nuxt support out of the box.

But thank you anyway for the prompt reply.

@koresar koresar closed this as completed Apr 3, 2019
@manniL
Copy link
Member

manniL commented Apr 3, 2019

Keeping it open anyway 😌

@manniL manniL reopened this Apr 3, 2019
@manniL manniL changed the title BUG: Configuration in modules: [] does not work Feature: accept module options Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manniL @koresar