Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Authorization tokens for CI #3

Closed
TDDR opened this issue Mar 9, 2022 · 4 comments · Fixed by #4
Closed

Set up Authorization tokens for CI #3

TDDR opened this issue Mar 9, 2022 · 4 comments · Fixed by #4

Comments

@TDDR
Copy link
Contributor

TDDR commented Mar 9, 2022

Before we can start officially using our registry, we must set up authorization tokens for our CI pipeline.

image

https://github.com/cesanta/docker_auth/blob/main/examples/reference.yml#L122-L163

@humphd
Copy link
Contributor

humphd commented Mar 9, 2022

The fastest path to having something usable soon might be to do static users defined in the config file:

https://github.com/cesanta/docker_auth/blob/main/examples/simple.yml

We couldn't put that in git, but we could do it on the server. This might let us get this into production within the week vs waiting on a perfect solution. Thoughts?

cc @manekenpix, @Kevan-Y for thoughts.

@manekenpix
Copy link
Contributor

@humphd 👍

@Kevan-Y
Copy link
Contributor

Kevan-Y commented Mar 9, 2022

@humphd That would be a simple way, and maybe the best way for now for CI pipeline.
I was also searching if we setup auth with GitHub https://github.com/cesanta/docker_auth/blob/main/examples/reference.yml#L122-L163 how we gonna do the CI with that.

# GitHub authentication.
# ==! NB: DO NOT ENTER YOUR GITHUB PASSWORD AT "docker login". IT WILL NOT WORK.
# Instead, Auth server maintains a database of GitHub authentication tokens.
# Go to the server's port as HTTPS with your browser and follow the "Login with GitHub account" link.
# Once signed in, you will get a throw-away password which you can use for Docker login.

Seems like user have to go to browser to login, that what I understand, not sure if I misunderstand that.

@humphd
Copy link
Contributor

humphd commented Mar 10, 2022

I propose that we modify our docker-compose file to add a volume for the config, but that we don't provide the actual config in git. We'll manually create it in the server and include the right usernames and passwords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants