Add Tic-Tac-Toe Game code in python #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakshamarora1
suggested changes
Oct 20, 2020
| @@ -0,0 +1,282 @@ | |||
| # Tic-Tac-Toe game for multiplayer | |||
There was a problem hiding this comment.
Suggested change
| # Tic-Tac-Toe game for multiplayer | |
| # Tic-Tac-Toe |
Comment on lines
3
to
4
| ## Tic-Tac-Toe | ||
| Tic-Tac-Toe is a multiplayer simple game. |
There was a problem hiding this comment.
This is redundant. If you want to add stuff about the working of the code you can do so under the Description sub-heading
|
|
||
| ## Code | ||
| ```python | ||
|
|
| ```python | ||
|
|
||
| from os import system, name | ||
|
|
|
|
||
| # import sleep to show output for some time period | ||
| from time import sleep | ||
|
|
Comment on lines
20
to
21
|
|
||
| # for mac and linux(here, os.name is 'posix') |
There was a problem hiding this comment.
Suggested change
| # for mac and linux(here, os.name is 'posix') | |
| # for mac and linux(here, os.name is 'posix') |
|
|
||
|
|
||
| clear() | ||
| str1 = "." |
There was a problem hiding this comment.
Can you come up with a better informative naming for these variables. For example, box1, block1, etc.
This goes for all the other variables too. To make it easier for other people to comprehend what's happening without wasting too much time!
sakshamarora1
approved these changes
Oct 22, 2020
sakshamarora1
added
hacktoberfest
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Tic-Tac-Toe Game code in python
Fixes: #14
Type of change
Checklist: