Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevToys shouldn't register itself as a file picker #746

Closed
JaiganeshKumaran opened this issue Jan 22, 2023 · 3 comments · Fixed by #747
Closed

DevToys shouldn't register itself as a file picker #746

JaiganeshKumaran opened this issue Jan 22, 2023 · 3 comments · Fixed by #747

Comments

@JaiganeshKumaran
Copy link
Contributor

Screenshot 2023-01-22 at 14 06 34

Remove from the manifest:

<uap:Extension Category="windows.fileOpenPicker">
    <uap:FileOpenPicker>
        <uap:SupportedFileTypes>
            <uap:SupportsAnyFileType/>
        </uap:SupportedFileTypes>
    </uap:FileOpenPicker>
</uap:Extension>
@veler
Copy link
Collaborator

veler commented Jan 23, 2023

Hello,

Thanks for your feedback. This is required in order to allow customers to open any kind of file in the app using this kind of button that you find at multiple places in the app. Not sure if I can workaround that.

image

@JaiganeshKumaran
Copy link
Contributor Author

Hello,

Thanks for your feedback. This is required in order to allow customers to open any kind of file in the app using this kind of button that you find at multiple places in the app. Not sure if I can workaround that.

image

For that, you can just add "*" as a file type filter.

@veler veler closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
@BreeceW
Copy link

BreeceW commented Mar 23, 2023

@veler I believe you are confusing the FileOpenPicker API with the Windows extension. The FileOpenPicker API that you are using throughout the app allows users to pick any file because you have correctly set FileOpenPicker.FileTypeFilter.Add("*").

Totally unrelated, the Windows extension exists so when users open a file picker from another app, they can select an app as if it were a folder and the app provides a file. Declaring <uap:SupportsAnyFileType /> is saying that DevToys should show up as a picker for every type of file in other UWP apps. But DevToys is not a picker (and so it should not declare that it is) and does not even implement the extension despite the declaration, so it just opens as a dead splash screen for every file type.

#747 should be merged. Users will still be able to open any file in DevToys, and they won’t see a broken DevToys entry cluttering other file pickers.

As you can see, any kind of file can still be opened in DevToys without that declaration.
File open picker open in DevToys with the diff showing the extension in the manifest deleted and all files still being an option

@veler veler reopened this Apr 5, 2023
@veler veler closed this as completed in #747 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants