Adding Puml commands work to puml api #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the after command calls - applied the currently sketched logic for the puml-sequence command - applied the currently sketched logic for the after-sequence-generate method - pushing to remote for testing in gitpod
…testing altering the command check order - trying to implement and update the legacy sequence use case logic - updated to use dot referencing that is now supposed to be available, but having issues getting the instance portion to populate correctly. Going to try swapping to the structure and use key referencing
…d into the generate method, it is not being seen as a dictionary like thought, so need to re-work/re-evaluate the output of the sorting method for populating the diagram output with generate
…orrying about fully passing into generate
…for handling the sorting to leverage for populating template output
…- trying to now get the content of the participants
…f the steps like in participants
… debug messages - now to try and utilize within generate command
…wing to generate, confirmed it can make it correctly to the arfter sequence method - tweaked init to reflect changes to puml sequence return
…rying to get generate portion to execute correctly
…correct data source referencing
… has the templates handling more of the data transformation than legacy so the primary rework of the legacy sorting and transforming of the model data to the diagram entries falls within the template tasks
…ntries in the pyproject - corrected test location so tox and unittest see the file correctly
lizzcondrey
added
the
added
…ers file - correcting some linting errors
…ting request - corrected success message notice to confirm output - cleaned up generator definition
… some linting clean up in puml impl file
…ackage of the standalone plugins
… diagrams, populating will be completed within the template tasks since the templates are now responsible for transforming the model data to the needed diagram data.
|
Should just be the unit test step failing, and till we have the templates in place we won't be able to complete them currently. So each template task will also add the unit test. But this should be solid for review now. Also, this might be able to then just roll to main. But because it was branched from api, it has to merge to there first to limit conflicts and such. |
lizzcondrey
changed the title
bunchw
reviewed
Apr 10, 2024
bunchw
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch focused on the work necessary for re-implementing the puml-sequence command with the new data flows, data object, and API.
Linked Items:
N/A
Added
Checklist: