Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-grid): add the ability to prevent editing by a column #729

Merged
merged 11 commits into from
Feb 15, 2018

Conversation

SergeyAlexeev
Copy link
Contributor

No description provided.

@KaiWynn
Copy link

KaiWynn commented Feb 9, 2018

How do I install this new feature?

@MaximKudriavtsev
Copy link
Contributor

Hi @KaiWynn,

This feature will be available in the next release.

@KaiWynn
Copy link

KaiWynn commented Feb 9, 2018

Thank you.

Field | Type | Description
------|------|------------
columnName | string | The name of a column to extend.
editingEnabled | boolean | Specifies whether editing is enabled for a column.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed optionality

@@ -13,7 +13,8 @@ none
Name | Type | Default | Description
-----|------|---------|------------
createRowChange | (row: any, columnName: string, value: string | number) => any | | A function that returns a row change object depending on row editor values. This function is called each time the row editor's value changes.
columnExtensions | Array<[EditingColumnExtension](#editingcolumnextension)> | | Additional column properties that the plugin can handle.
columnEditingEnabled | boolean | true | Specifies whether editing is enabled for all columns.
columnExtensions | Array<[EditingStateColumnExtension](#editingstatecolumnextension)> | | Additional column properties that the plugin can handle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed optionality

@@ -13,7 +13,8 @@ none
Name | Type | Default | Description
-----|------|---------|------------
createRowChange | (row: any, columnName: string, value: string | number) => any | | A function that returns a row change object depending on row editor values. This function is called each time the row editor's value changes.
columnExtensions | Array<[EditingColumnExtension](#editingcolumnextension)> | | Additional column properties that the plugin can handle.
columnEditingEnabled | boolean | true | Specifies whether editing is enabled for all columns.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed optionality

@@ -30,15 +31,14 @@ onCommitChanges | (Array<[ChangeSet](#change-set)>) => void | | Handles ro

## Interfaces

### EditingColumnExtension
### EditingStateColumnExtension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EditingState.ColumnExtension

@SergeyAlexeev SergeyAlexeev merged commit 3c88c4c into DevExpress:master Feb 15, 2018
@SergeyAlexeev SergeyAlexeev deleted the prevent-row-editing branch February 15, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants