Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(react-grid): rename the EditingState plugin properties #650

Merged
merged 2 commits into from
Jan 10, 2018
Merged

refactor(react-grid): rename the EditingState plugin properties #650

merged 2 commits into from
Jan 10, 2018

Conversation

MaximKudriavtsev
Copy link
Contributor

@MaximKudriavtsev MaximKudriavtsev commented Jan 10, 2018 •
edited
Loading

BREAKING CHANGES:

The following EditingState plugin's properties have been renamed to improve the API consistency:

  • editingRows => editingRowIds
  • defaultEditingRows => defaultEditingRowIds
  • onEditingRowsChange => onEditingRowIdsChange

The editingRows getter has been renamed to editingRowIds.

@MaximKudriavtsev MaximKudriavtsev changed the title refactor(react-grid): rename the EditingState plugin propertyes refactor(react-grid): rename the EditingState plugin properties Jan 10, 2018
@MaximKudriavtsev MaximKudriavtsev merged commit 4d7fe82 into DevExpress:master Jan 10, 2018
@MaximKudriavtsev MaximKudriavtsev deleted the rename-editingRows branch January 10, 2018 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvet kvet kvet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximKudriavtsev @kvet