-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react-grid): switch to column extensions in LocalSorting #603
Conversation
|
||
const pluginDependencies = [ | ||
{ pluginName: 'SortingState' }, | ||
]; | ||
|
||
export class LocalSorting extends React.PureComponent { | ||
render() { | ||
const { getColumnCompare } = this.props; | ||
const { columnExtensions } = this.props; | ||
const getColumnCompare = columnName => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change getColumnCompare
to columnCompare
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the getColumnCompare
name in order to make it consistent across local processing plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…ctive into local-sorting-column-extension
BREAKING CHANGES:
We removed the
getColumnCompare
property from the LocalSorting plugin to improve API consistency. Now, use thecolumnExtension
property to specify individual column sorting options.Before:
After: