refactor(react-grid): replace render functions with components in TableRowDetail #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvet
changed the title
| contentComponent | ElementType<[DetailContentProps](#detailcontentprops)> | | A component that renders row details. | ||
| cellComponent | ElementType<[TableDetailCellProps](#tabledetailcellprops)> | | A component that renders a detail cell. | ||
| rowComponent | ElementType<[TableDetailRowProps](#tabledetailrowprops)> | | A component that renders a detail row. | ||
| toggleCellComponent | ElementType<[TableDetailToggleCellProps](#tabledetailtogglecellprops)> | | A component that renders the detail toggle control. |
There was a problem hiding this comment.
toggleCellComponent - A component that renders the detail toggle control.
It isn't clear what this component renders cell or toggle control.
| cellComponent | ElementType<[TableDetailCellProps](#tabledetailcellprops)> | | A component that renders a detail cell. | ||
| rowComponent | ElementType<[TableDetailRowProps](#tabledetailrowprops)> | | A component that renders a detail row. | ||
| toggleCellComponent | ElementType<[TableDetailToggleCellProps](#tabledetailtogglecellprops)> | | A component that renders the detail toggle control. | ||
| toggleColumnWidth | number | | Specifies the detail toggle cell width. |
There was a problem hiding this comment.
toggleColumnWidth -> Specifies the detail toggle cell width.
|
|
||
| A value with the [TableRowProps](table.md#tablerowprops) shape extended by the following fields: | ||
|
|
||
| Field | Type | Description | ||
| ------|------|------------ | ||
| row | any | A row. | ||
|
|
||
| ### <a name="detail-toggle-args"></a>DetailToggleArgs | ||
| ### TableDetailToggleCellProps |
There was a problem hiding this comment.
Is the Table prefix required?
There was a problem hiding this comment.
It is not required. But I don't think that the name is important enough to change it. We will review them with TypeScript/FlowType definitions adding.
gsobolev
approved these changes
Nov 29, 2017
viterobk
approved these changes
Nov 29, 2017
dirk-pieterse
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
The TableRowDetail plugin's
detailToggleCellWidthproperty has been renamed totoggleColumnWidth. Thetemplate,detailCellTemplate,detailRowTemplate, anddetailToggleCellTemplateproperties have been replaced withcontentComponent,cellComponent,rowComponent, andtoggleCellComponentones, which accept components instead of render functions. Find more details here: #496Properties passed to
cellComponenthave the same names as arguments passed to thedetailCellTemplatefunction except for thechildrenproperty, which is used instead of thetemplateargument.Properties passed to
toggleCellComponenthave the same names as arguments passed to thedetailToggleCellTemplatefunction except for theonToggleproperty, which is used instead of thetoggleExpandedargument.