feat(react-grid): support expanding/collapsing detail rows with keyboard #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsobolev
reviewed
Oct 26, 2017
| /> | ||
| </td> | ||
| ); | ||
| onKeyDown={handleKeyDown} |
There was a problem hiding this comment.
Why not subscribe the element with tabIndex on these events?
| const handleBlur = (e) => { | ||
| e.target.style.outline = ''; | ||
| }; | ||
| const handleMouseDownChildren = (e) => { |
There was a problem hiding this comment.
Why do we need this handler?
| style={style} | ||
| > | ||
| <IconButton | ||
| tabIndex={0} // eslint-disable-line jsx-a11y/no-noninteractive-tabindex |
There was a problem hiding this comment.
Looks like there is no need to explicitly specify the tabIndex property for the button element. It can get focus by default.
| marginLeft: '-6px', | ||
| height: theme.spacing.unit * 6, | ||
| width: theme.spacing.unit * 6, | ||
| marginLeft: '-18px', |
There was a problem hiding this comment.
Is not it possible to use theme.spacing.unit here?
| textOverflow: 'initial', | ||
| paddingTop: '0px', | ||
| paddingBottom: '0px', | ||
| }, | ||
| toggleCellIcon: { |
There was a problem hiding this comment.
Maybe rename this property to "toggleCellButton"?
|
|
||
| export const TableDetailToggleCell = ({ style, expanded, toggleExpanded }) => { | ||
| const handleKeyDown = (event) => { | ||
| if (event.keyCode === 13) { |
There was a problem hiding this comment.
Please extract the "magic number" to a human-readable constant.
gsobolev
reviewed
Oct 27, 2017
| .toBe(0); | ||
| }); | ||
|
|
||
| it('should handle the "Enter" key down', () => { |
SergeyAlexeev
approved these changes
Oct 27, 2017
gsobolev
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.