feat(react-grid): support custom grouping processing #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ], | ||
| }]; | ||
| const getHierarchicalChildGroups = groups => groups | ||
| .map(group => ({ key: String(group.key), value: group.key, nestedData: group.items })); |
There was a problem hiding this comment.
Can we extract duplicated code? I mean something like this:
const createGetChildGroupsMock = (groups) => {
const getHierarchicalChildGroups = groups => groups
.map(group => ({ key: String(group.key), value: group.key, nestedData: group.items }));
return jest.fn(getHierarchicalChildGroups);
};There was a problem hiding this comment.
I don't like decreasing tests readability as it will not reduce loc count dramatically.
| import { mount } from 'enzyme'; | ||
| import Demo from './local-grouping-static'; | ||
|
|
||
| describe('BS3: grouping with custom', () => { |
There was a problem hiding this comment.
The test suite name sounds strange
| data: [{ | ||
| key: 'Male', | ||
| items: generateRows({ | ||
| columnValues: { ...defaultColumnValues, sex: ['Female'] }, |
There was a problem hiding this comment.
Is this sex: ['Female'] correct for Male group?
gsobolev
approved these changes
Oct 16, 2017
SergeyAlexeev
approved these changes
Oct 17, 2017
viterobk
approved these changes
Oct 18, 2017
dxbykov
approved these changes
Oct 24, 2017
dirk-pieterse
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.