fix: conditional type exports (T1177805) #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const314
approved these changes
Jul 28, 2023
timbset
requested changes
Jul 28, 2023
Co-authored-by: Timofey Traynenkov <[email protected]>
timbset
approved these changes
Jul 28, 2023
timbset
requested changes
Jul 28, 2023
scripts/merge-dts.js
Outdated
| const pkg = JSON.parse(readFileSync(join(packageDirectory, 'package.json'))); | ||
| const dtsOutFile = join(packageDirectory, pkg.types); | ||
| const pkg = getPackageInfo(packageDirectory); | ||
| const dtsOutFile = getDtsOutFile(packageDirectory, pkg.types); |
There was a problem hiding this comment.
Looks like an overcomplicating. What's the difference between your function and using join?
scripts/utils.js
Outdated
|
|
||
| export const getPackageInfo = packageDir => JSON.parse(readFileSync(join(packageDir, 'package.json'))); | ||
|
|
||
| export const getDtsOutFile = (packageDir, typesDir) => join(packageDir, typesDir); |
There was a problem hiding this comment.
We've simply duplicated using of join. Remove this function
| @@ -21,8 +21,8 @@ export default (packageDirectory, skipBundle = false) => { | |||
| const dtsPath = join(packageDirectory, 'dist', 'dts'); | |||
|
|
|||
| if (!skipBundle) { | |||
| const pkg = JSON.parse(readFileSync(join(packageDirectory, 'package.json'))); | |||
| const dtsOutFile = join(packageDirectory, pkg.types); | |||
| const pkg = getPackageInfo(packageDirectory); | |||
There was a problem hiding this comment.
I think it is better to split this on steps instead of extracting this logic into util function
timbset
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with https://github.com/arethetypeswrong/arethetypeswrong.github.io, before/after: