feat(react-grid): provide the custom data accessors capability #264
Conversation
…ctive into nested-keys-implementation
SergeyAlexeev
changed the title
dxbykov
changed the title
| @@ -16,3 +16,19 @@ export const addedRowsByIds = (addedRows, rowIds) => { | |||
| }); | |||
| return result; | |||
| }; | |||
|
|
|||
| export const rowChange = (columns, createRowChange) => { | |||
| title: 'First Name', | ||
| getCellData: row => (row.user ? row.user.firstName : undefined), | ||
| createRowChange: (row, columnName, value) => | ||
| (Object.assign(row.user || { user: {} }, { firstName: value })), |
There was a problem hiding this comment.
In case of row.user is undefined the result will look as { user: {}, firstName: value }
|
|
||
|
|
||
| Pay attention, the `getCellData` property of the Grid has a higher priority than the `column.getCellData` one. | ||
|
|
There was a problem hiding this comment.
I would also make a note, that it's a performance-critical place. Since the getCellData method is called lots of times it should be implemented in an optimal way. This demo code shouldn't be used in productions apps with a large amount of data.
| { | ||
| ... | ||
| createRowChange: (row, columnName, value) => | ||
| (Object.assign(row.user || { user: {} }, { firstName: value })), |
There was a problem hiding this comment.
Same issue as mentioned above.
| @@ -105,6 +106,7 @@ export class EditingState extends React.PureComponent { | |||
| const changedRows = this.props.changedRows || this.state.changedRows; | |||
| const addedRows = this.props.addedRows || this.state.addedRows; | |||
| const deletedRows = this.props.deletedRows || this.state.deletedRows; | |||
| const createRowChange = this.props.createRowChange || this.state.createRowChange; | |||
There was a problem hiding this comment.
Can createRowChange be in the state?
| return { | ||
| value: column.name in change ? change[column.name] : row[column.name], | ||
| value: getCellData(change, column.name) || getCellData(row, column.name), |
There was a problem hiding this comment.
if change = { user: undefined } and row = { user: 'A user' }, then the value will be 'A user' but should be undefined.
…yAlexeev/devextreme-reactive into nested-keys-implementation
| @@ -34,6 +35,8 @@ A value with the following shape: | |||
| Field | Type | Description | |||
| ------|------|------------ | |||
| name | string | Specifies the field name in the data row to obtain a column value. A unique key can also be used to identify a column | |||
| getCellData | (row: [Row](#row), columnName: string) => any | Specifies the function used to get a cell data | |||
| createRowChange | (row: [Row](#row), columnName: string, value: string | number) => object | Specifies the function used to create a row change | |||
There was a problem hiding this comment.
createRowChange should be defined in EditingState's Column interface extension
There was a problem hiding this comment.
Also seems that the columnName argument should be the last because it will not be frequently used
…yAlexeev/devextreme-reactive into nested-keys-implementation
No description provided.