feat(react-scheduler): add mobile adaptability to the Scheduler #2497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AryamnovEugeniy
requested review from
churkin,
MaximKudriavtsev and
LazyLahtak
AryamnovEugeniy
changed the title
|
Should we change the text size in the EditRecurrenceMenu? |
|
|
|
|
| </Grid> | ||
| </Grid> | ||
|
|
||
| <Grid item xs="auto"> | ||
| <Grid container direction="row"> | ||
| <Grid item xs={1}> | ||
| <div className={classes.timeScale}> |
There was a problem hiding this comment.
Why timeScale applies to two places and one of them DayScale?
|
FPR |
LazyLahtak
approved these changes
Oct 29, 2019
| @@ -12,7 +12,7 @@ import { appointments } from '../../../demo-data/appointments'; | |||
| const formatDayScaleDate = (date, options) => { | |||
| const momentDate = moment(date); | |||
| const { weekday } = options; | |||
| return momentDate.format(weekday ? 'dddd' : 'D'); | |||
| return momentDate.format(weekday ? 'dd' : 'D'); | |||
There was a problem hiding this comment.
Maybe we just add a text-overflow: elipsis without change formating?
Comment on lines
12
to
14
| title: { | ||
| ...typography.h6, | ||
| }, |
There was a problem hiding this comment.
title: typography.h6,
MaximKudriavtsev
approved these changes
Oct 30, 2019
|
FPR |
churkin
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
