feat(scheduler-core): time scale should take fractional startDayHour/endDayHour values #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churkin
changed the title
AryamnovEugeniy
approved these changes
Oct 4, 2019
|
Can we update our documentation to inform customers about updates? I mean adding the following sentence |
MaximKudriavtsev
approved these changes
Oct 9, 2019
|
@RomanTsukanov ping |
| @@ -31,8 +31,8 @@ displayName? | string | | The view's name used in UI plugins. The default value | |||
| excludedDays? | Array<number> | [] | Specifies the days of week that should not be displayed in the view. Accepts an array of zero-bazed day indexes (0 - Sunday). | |||
| intervalCount? | number | 1 | Multiplies the default view interval. | |||
| cellDuration? | number | 30 | Specifies the cell's duration in minutes. | |||
| startDayHour? | number | 0 | Specifies the start hour of the view time scale. | |||
| endDayHour? | number | 24 | Specifies the end hour of the view time scale. | |||
| startDayHour? | number | 0 | Specifies the start hour of the view time scale. Accepts floating values from 0 to 24. | |||
There was a problem hiding this comment.
Suggested change
| startDayHour? | number | 0 | Specifies the start hour of the view time scale. Accepts floating values from 0 to 24. | |
| startDayHour? | number | 0 | Specifies the start hour of the view time scale. Accepts floating-point numbers from 0 to 24. |
| startDayHour? | number | 0 | Specifies the start hour of the view time scale. | ||
| endDayHour? | number | 24 | Specifies the end hour of the view time scale. | ||
| startDayHour? | number | 0 | Specifies the start hour of the view time scale. Accepts floating values from 0 to 24. | ||
| endDayHour? | number | 24 | Specifies the end hour of the view time scale. Accepts floating values from 0 to 24. |
There was a problem hiding this comment.
Suggested change
| endDayHour? | number | 24 | Specifies the end hour of the view time scale. Accepts floating values from 0 to 24. | |
| endDayHour? | number | 24 | Specifies the end hour of the view time scale. Accepts floating-point numbers from 0 to 24. |
added 3 commits
October 10, 2019 13:08
|
FPR |
RomanTsukanov
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.