fix(react-grid): correct changing DataTypeProvider.for property in runtime #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LazyLahtak
changed the title
|
FPR |
ushkal
reviewed
Jul 30, 2019
| <DataTypeProvider | ||
| for={['test']} | ||
| getAvailableFilterOperations={() => {}} | ||
| /> | ||
| {pluginDepsToComponents({})} |
ushkal
reviewed
Jul 30, 2019
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| columnNames: [`${defaultDeps.getter.tableColumns[0].column.name}`], |
There was a problem hiding this comment.
``${` is redundant here, use simple quotes instead
ushkal
reviewed
Jul 30, 2019
| <Template name="table"> | ||
| <div> | ||
| <TemplateConnector> | ||
| {({ tableColumns }) => ( |
ushkal
reviewed
Jul 30, 2019
| const defaultDeps = { | ||
| getter: { | ||
| tableColumns: [ | ||
| { key: `${TABLE_DATA_TYPE}_a`, type: TABLE_DATA_TYPE, column: { name: 'a' } }, |
There was a problem hiding this comment.
We don't need type here. Besides that, TABLE_DATA_TYPE is undefined since grid-core is mocked
ushkal
reviewed
Jul 30, 2019
| </PluginHost> | ||
| )); | ||
| expect(getComputedState(tree).getAvailableFilterOperations) | ||
| .toEqual(expect.any(Function)); | ||
| }); | ||
|
|
||
| it('should re-register templates when "for" property changed in runtime', () => { |
There was a problem hiding this comment.
We need a similar test against valueEditor
ushkal
reviewed
Jul 30, 2019
|
|
||
| const tree = mount(<Test />); | ||
|
|
||
| expect(tree |
There was a problem hiding this comment.
Simplify this: just check a formatterComponent's props
|
FPR |
ushkal
reviewed
Jul 31, 2019
|
|
||
| it('should re-register valueFormatter templates', () => { | ||
| const DataFormatter = () => null; | ||
| const tree = mount(<Test |
There was a problem hiding this comment.
We use another formatting:
mount((
<Test ... />
))
churkin
approved these changes
Jul 31, 2019
|
FPR |
ushkal
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2047