Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-chart): improve touch events on hover/select #2159

Merged
merged 5 commits into from
Jul 12, 2019

Conversation

Krijovnick
Copy link
Contributor

No description provided.

@MaximKudriavtsev
Copy link
Contributor

I suggest some changes

  • Can we combine old behavior with the new? I mean that touchstart + touchmove.
  • How a customer can hide a hover on a mobile device?
  • I suggest renaming this PR. We should use a verb in the first place that describes changes type. In my opinion, touch events on hover/select is not clear to understand.
  • Why we use chore in this title? The changes change behavior and our customers should know about it from our CHANGELOG.md

@Krijovnick
Copy link
Contributor Author

  1. We can do that, but It is interesting question: Will user move finger on screen to change the hover/selection? I think no.
  2. Customer can touch the empty area to hide a hover.
  3. and 4. Ok, I will change it.

@Krijovnick Krijovnick changed the title chore(react-chart): touch events on hover/select fix(react-chart): improve touch events on hover/select Jul 11, 2019
@Krijovnick Krijovnick merged commit 61ee79a into DevExpress:master Jul 12, 2019
@Krijovnick Krijovnick deleted the touch_on_tracker branch July 12, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants