Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-chart): property to customize scale domain #1711

Conversation

DmitryBogomolov
Copy link
Contributor

@DmitryBogomolov DmitryBogomolov commented Dec 18, 2018

Add modifyDomain scale property. Removes min and max scale properties.

BREAKING CHANGES:

The min and max scale properties are replaced with the modifyDomain property because the band scale domain cannot be customized in min and max terms.

Replace this

<ArgumentScale min={0} max={10} ... />

with this

const modifyDomain = () => [0, 10];

<ArgumentScale modifyDomain={modifyDomain} ... />

@DmitryBogomolov DmitryBogomolov merged commit b09e439 into DevExpress:master Dec 18, 2018
@DmitryBogomolov DmitryBogomolov deleted the customize-scale-domain-property branch December 18, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants